Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup(cli/lsp): use op Extensions #13225

Merged
merged 1 commit into from
Dec 29, 2021
Merged

cleanup(cli/lsp): use op Extensions #13225

merged 1 commit into from
Dec 29, 2021

Conversation

AaronO
Copy link
Contributor

@AaronO AaronO commented Dec 29, 2021

Since registering ops declaratively is a best practice

@AaronO
cleanup(cli/lsp): use op Extensions
14f0836 
Since registering ops declaratively is a best practicec
bartlomieju
bartlomieju approved these changes Dec 29, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AaronO AaronO merged commit 42777f2 into denoland:main Dec 29, 2021
@AaronO AaronO deleted the cleanup/cli-lsp-extension-ops branch December 29, 2021 14:22
bartlomieju pushed a commit that referenced this pull request Jan 5, 2022
@AaronO @bartlomieju
cleanup(cli/lsp): use op Extensions (#13225)
0537d82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@dsherret dsherret Awaiting requested review from dsherret

@kitsonk kitsonk Awaiting requested review from kitsonk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AaronO @bartlomieju