Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): include JSON modules in bundle #13188

Merged
merged 2 commits into from
Dec 23, 2021
Merged

fix(cli): include JSON modules in bundle #13188

merged 2 commits into from
Dec 23, 2021

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Dec 23, 2021

Fixes #13150

@andreubotella
Copy link
Contributor

Note that this will output incorrect sourcemaps with Deno.emit(), since the byte offsets are into the mapped source. I tried to hack around this with a custom implementation of Input that treated all positions before the start of the JSON as 0, but I didn't get very far with it.

This is not a blocker for this PR, but it should probably be fixed before the next patch release.

bartlomieju
bartlomieju approved these changes Dec 23, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Andreu has c good point regarding source maps.

cli/ast/mod.rs Show resolved Hide resolved
dsherret
dsherret approved these changes Dec 23, 2021
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the two issues are fixed.

cli/ast/mod.rs Outdated Show resolved Hide resolved
@kitsonk
Copy link
Contributor Author

kitsonk commented Dec 23, 2021

Note that this will output incorrect sourcemaps with Deno.emit(), since the byte offsets are into the mapped source. I tried to hack around this with a custom implementation of Input that treated all positions before the start of the JSON as 0, but I didn't get very far with it.

This is not a blocker for this PR, but it should probably be fixed before the next patch release.

Yeah, I realised it when I did it that it would "mess" things up, but I plan to mop it up, along with other things as part of #13021.

@kitsonk kitsonk merged commit 37dbe52 into denoland:main Dec 23, 2021
@kitsonk kitsonk deleted the kitsonk/issue13150 branch December 23, 2021 22:38
@andreubotella andreubotella mentioned this pull request Dec 24, 2021
Closed
bartlomieju pushed a commit that referenced this pull request Jan 5, 2022
@kitsonk @bartlomieju
fix(cli): include JSON modules in bundle (#13188)
cd40d81 
Fixes #13150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deno bundle not working with JSON module
4 participants
@kitsonk @andreubotella @dsherret @bartlomieju