Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use once_cell instead of lazy_static #13135

Merged
merged 4 commits into from
Dec 18, 2021
Merged

refactor: use once_cell instead of lazy_static #13135

merged 4 commits into from
Dec 18, 2021

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Dec 18, 2021 •
edited
Loading

Motivation

Note: we already had once_cell as dependency before

@littledivy littledivy changed the title refactor: use once_cell instead of lazy_static refactor: use once_cell instead of lazy_static Dec 18, 2021
dsherret
dsherret approved these changes Dec 18, 2021
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

bartlomieju
bartlomieju approved these changes Dec 18, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too; we still it as a direct dependency in two of our crates:

  • deno_doc
  • deno_graph
    and as transitive dependency in multiple other crates, but it seems like lazy_static is being slowly fazed out.

@dsherret dsherret merged commit 6de53b6 into denoland:main Dec 18, 2021
@littledivy littledivy deleted the once_cell branch December 19, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

@bartlomieju bartlomieju bartlomieju approved these changes

@bnoordhuis bnoordhuis Awaiting requested review from bnoordhuis

@kitsonk kitsonk Awaiting requested review from kitsonk

@lucacasonato lucacasonato Awaiting requested review from lucacasonato

@piscisaureus piscisaureus Awaiting requested review from piscisaureus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@littledivy @dsherret @bartlomieju