Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(repl): support assertions on import & export declarations #13121

Merged
merged 2 commits into from
Dec 17, 2021
Merged

fix(repl): support assertions on import & export declarations #13121

merged 2 commits into from
Dec 17, 2021

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Dec 17, 2021 •
edited
Loading

image

Closes #13115

bartlomieju
bartlomieju approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 5d8baf0 into denoland:main Dec 17, 2021
@dsherret dsherret deleted the repl_fix_import_assertions_on_declarations branch December 17, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@kitsonk kitsonk Awaiting requested review from kitsonk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support import assertions on import declarations in the REPL
2 participants
@dsherret @bartlomieju