Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): Make the op sanitizer delay macrotask into a queue #12966

Merged
merged 1 commit into from
Dec 10, 2021
Merged

fix(test): Make the op sanitizer delay macrotask into a queue #12966

merged 1 commit into from
Dec 10, 2021

Conversation

andreubotella
Copy link
Contributor

Fixes #12945.

@andreubotella andreubotella mentioned this pull request Dec 2, 2021
Closed
@bartlomieju
Copy link
Member

@andreubotella is this ready for review?

@andreubotella andreubotella marked this pull request as ready for review December 10, 2021 15:47
bartlomieju
bartlomieju reviewed Dec 10, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is reasonable for me; @dsherret what do you think?

@andreubotella
Copy link
Contributor Author

@andreubotella is this ready for review?

Yeah. I wasn't sure if this was the best way to fix #12945, since having a single delay macrotask is only a problem if test steps are misused, but making it a queue is probably the easiest way to get rid of the flakes.

dsherret
dsherret approved these changes Dec 10, 2021
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@dsherret dsherret merged commit a3aa2c1 into denoland:main Dec 10, 2021
@andreubotella andreubotella deleted the op-sanitizer-delay-resolve-queue branch December 10, 2021 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju left review comments

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

integration::test::steps_invalid_usage is flaky
3 participants
@andreubotella @bartlomieju @dsherret