feat(runtime): add op_set_exit_code #12911
Conversation
cli/dts/lib.deno.unstable.d.ts
Outdated
| * Deno.exit(); // Exits with status code 42. | ||
| * ``` | ||
| */ | ||
| export function setExitCode(code: number): void; |
There was a problem hiding this comment.
I'm not yet convinced we want to expose it as Deno API; maybe let's go with "hidden op" approach we discussed last time? Ie. there's an op to set it, but we don't expose it as Deno API right now.
There was a problem hiding this comment.
It doesn't really matter when it's behind --unstable, I think?
At any rate, I can't seem to call Deno.core.opSync("op_set_exit_code", 42) from std/node. It doesn't show up in Deno.core.ops() (whereas e.g. op_exit does) and when I invoke it, I get this:
Uncaught TypeError: invalid op id: expected type `v8::data::Integer`, got `v8::data::Value`
(Which is a terribly misleading error message, by the way.)
There was a problem hiding this comment.
Okay, belay that - it works after a full rebuild. I'll change it if you feel strongly but 🤷
Set the exit code to use if none is provided to Deno.exit(), or when Deno exits naturally. Needed for process.exitCode Node compat. Paves the way for denoland#12888.
bnoordhuis
force-pushed
the
set-exit-code
branch
from
d2d231e
to
b0550a5
Compare
|
Decided to use an op after all. :-) |
bnoordhuis
changed the title
Set the exit code to use if none is provided to Deno.exit(), or when
Deno exits naturally.
Needed for process.exitCode Node compat. Paves the way for #12888.