Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lsp): normalize urls in did_change_watched_files #12873

Merged
merged 1 commit into from
Nov 23, 2021
Merged

fix(lsp): normalize urls in did_change_watched_files #12873

merged 1 commit into from
Nov 23, 2021

Conversation

igorsaux
Copy link
Contributor

Fixes #12871

I've noticed that the rest of the functions handle URLs using normalize_url, but that was missing in did_change_watched_files.

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @igorsaux for reporting this problem and figuring out the solution! 🙂

@dsherret dsherret merged commit 3f8c3b8 into denoland:main Nov 23, 2021
@igorsaux igorsaux deleted the fix-lsp-urls branch November 23, 2021 17:41
piscisaureus pushed a commit to piscisaureus/deno that referenced this pull request Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lsp: config file does not reload on change
2 participants