reland #12332: refactor(ext/http): rewrite hyper integration and fix bug #12732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piscisaureus
commented
Nov 10, 2021
| @@ -84,6 +84,11 @@ | |||
| throw error; | |||
| } | |||
| if (nextRequest == null) { | |||
| // Work-around for servers (deno_std/http in particular) that call | |||
There was a problem hiding this comment.
I believe this is indicative of a problem with our API, in particular two dubious practices clash here:
HttpConnis automatically closed whenHttpConn.nextRequest()fails or returnsnull.Deno.upgradeWebSocket()doesn't actually do anything until the caller uses (returns) the response created byDeno.upgradeWebSocket().
There was a problem hiding this comment.
Deno.upgradeWebSocket() doesn't actually do anything until the caller uses (returns) the response created by Deno.upgradeWebSocket()
Why is this a problem? This was done intentionally. The Deno.upgradeWebSocket call is just a glorified new Response().
piscisaureus
commented
Nov 10, 2021
| // https://github.com/denoland/deno/pull/12732 | ||
| unitTest( | ||
| { permissions: { net: true } }, | ||
| async function httpConnAutoCloseDelayedOnUpgrade() { |
There was a problem hiding this comment.
Regression test for the deno_std/http problem that got #12332 reverted.
lucacasonato
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.