Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: non ascii buffer response in http server #12728

Merged
merged 4 commits into from
Nov 10, 2021
Merged

fix: non ascii buffer response in http server #12728

merged 4 commits into from
Nov 10, 2021

Conversation

lucacasonato
Copy link
Member

Test for #12724. The offending commit is c27ef0a.

@lucacasonato lucacasonato changed the title tests: http server non ascii buffer response fix: non ascii buffer response in http server Nov 10, 2021
AaronO
AaronO approved these changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@AaronO AaronO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for missing this

@lucacasonato lucacasonato merged commit 6af916c into denoland:main Nov 10, 2021
@lucacasonato lucacasonato deleted the non_ascii_uint8array branch November 10, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronO AaronO AaronO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lucacasonato @AaronO