Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update unstable Deno props for signal API #12723

Merged
merged 1 commit into from
Nov 10, 2021
Merged

fix: update unstable Deno props for signal API #12723

merged 1 commit into from
Nov 10, 2021

Conversation

bartlomieju
Copy link
Member

Closes #12722

cli/tests/testdata/raw_mode_cbreak.ts was referencing Deno.signal() but wasn't used anywhere so I removed it as well.

ry
ry reviewed Nov 10, 2021
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's strange that the tests didn't catch this. Is this because all the signal tests are in JS instead of TS?

@bartlomieju
Copy link
Member Author

It's strange that the tests didn't catch this. Is this because all the signal tests are in JS instead of TS?

All of our unit tests run with --unstable flag. And there were no more references to Deno.signal so there was nothing to catch.

ry
ry approved these changes Nov 10, 2021
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok - LGTM

@bartlomieju bartlomieju merged commit 8ce53dd into denoland:main Nov 10, 2021
@bartlomieju bartlomieju deleted the unstable_signal branch November 10, 2021 13:30
@bartlomieju bartlomieju mentioned this pull request Nov 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

@kitsonk kitsonk Awaiting requested review from kitsonk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: v1.16.0 --unstable option not working
2 participants
@bartlomieju @ry