Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "refactor(ext/http): rewrite hyper integration and fix bug (#12332)" #12704

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

lucacasonato
Copy link
Member

This reverts commit 5b1e537.

This change updates some behaviour that caused std/http to break. We will try to reland this for 1.16.1.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@lucacasonato lucacasonato merged commit 75793ba into denoland:main Nov 9, 2021
@lucacasonato lucacasonato deleted the revert_new_http branch November 9, 2021 11:10
@piscisaureus
Copy link
Member

Any background on exactly how this was breaking std/http?

@lucacasonato
Copy link
Member Author

Yes, the serve should handle websocket requests test in std/http/server_test.ts fails. Root cause seemed to be that previously Deno.closeing a Deno.HttpConn would not close websockets created by Deno.upgradeWebsocket, but now it does.

@piscisaureus
Copy link
Member

Yes, the serve should handle websocket requests test in std/http/server_test.ts fails.

Thanks for the pointer!

Root cause seemed to be that previously Deno.closeing a Deno.HttpConn would not close websockets created by Deno.upgradeWebsocket, but now it does.

That's not the root cause; closing HttpConn doesn't close websockets before nor after the patch.
It seems that this test is hanging because the TcpListener created by serve() stays open somehow.

@lucacasonato
Copy link
Member Author

@piscisaureus If you add some onerror handlers to the socket, you will see that the WebSocket never gets established.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants