fix(fetch): set content-length for empty POST/PUT #12703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might be useful to link to the spec in the comment |
This commit changes `fetch` to set `content-length: 0` on POST and PUT requests with no body.
lucacasonato
force-pushed
the
fix_fetch_content_length
branch
from
f9986a6
to
1601d3d
Compare
|
Are there no WPT tests for this? |
Couldn't find any. We should add some, but I didn't have the nerve to do it right now, considering we are releasing today 😉 |
|
Also fixes #11920 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes
fetchto setcontent-length: 0on POST and PUTrequests with no body.
The relevant fetch spec text:
Fixes #12597
Fixes #11920