fix(crypto): handling large key length in HKDF

[upendra1997]

test.js file contains content:

new Uint8Array(
  await globalThis.crypto.subtle.deriveBits(
    {
      name: "HKDF",
      hash: "SHA-1",
      salt: new Uint8Array(),
      info: new Uint8Array(),
    },
    await globalThis.crypto.subtle.importKey(
      "raw",
      new Uint8Array([0x00]),
      "HKDF",
      false,
      ["deriveBits"]
    ),
    ((20 * 255) << 3) + 8 // 20 is block size of sha1, 255 is the maximum number of iterations, + 1 byte
  )
);

by running cargo run < test.js

❯ cargo run < test.js       
    Finished dev [unoptimized + debuginfo] target(s) in 1.08s
     Running `target/debug/deno`
Deno 1.15.3
exit using ctrl+d or close()
Uncaught DOMException: The length provided for HKDF is too large

failing testcases before this fix:

failures:
    integration::compile::compile
    integration::compiler_api
    integration::js_unit_tests
    integration::run::_034_onload
    integration::run::_045_proxy
    integration::run::tls_connecttls
    integration::run::tls_starttls
    integration::test::allow_all
    integration::test::allow_none
    integration::test::steps_invalid_usage
    integration::test::steps_passing_steps
    integration::test::steps_passing_steps_concurrent
    integration::websocket
    integration::websocket_server_multi_field_connection_header
    integration::websocketstream
    integration::worker::workers

after the fix:

failures:
    integration::compile::compile
    integration::compiler_api
    integration::js_unit_tests
    integration::run::_034_onload
    integration::run::_045_proxy
    integration::run::tls_connecttls
    integration::run::tls_starttls
    integration::test::allow_all
    integration::test::allow_none
    integration::test::steps_invalid_usage
    integration::test::steps_passing_steps
    integration::test::steps_passing_steps_concurrent
    integration::websocket
    integration::websocket_server_multi_field_connection_header
    integration::websocketstream
    integration::worker::workers

this fixes issue #12589

[bartlomieju]

Thanks for the PR, can you provide a test case that exercise the change?

[upendra1997]

Thanks for the PR, can you provide a test case that exercise the change?

I have included the test in the pr description.

[bartlomieju]

Thanks for the PR, can you provide a test case that exercise the change?

I have included the test in the pr description.

@upendra1997 the test case should be included as an automated test that can run in CI; you can add it to cli/tests/unit/webcrypto_test.ts

[bartlomieju]

Prefer to use assertRejects

[upendra1997]

Hi,

Thank you for reviewing; please check new revision.

Thank you,
Upendra Upadhyay.

[bartlomieju]

LGTM, thank you @upendra1997