Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lsp): align ScriptElementKind to current versions of TypeScript/vscode #12663

Merged
merged 2 commits into from
Nov 9, 2021

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Nov 7, 2021

There has been a bit of "drift" in what TypeScript supports and what vscode does with information included in the navigation tree.

@kitsonk kitsonk requested a review from dsherret November 7, 2021 01:10
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@kitsonk kitsonk merged commit 31fde9d into denoland:main Nov 9, 2021
@kitsonk kitsonk deleted the chore_align_script_element_kind branch November 9, 2021 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants