Avoid memory leak #1265
Merged
Avoid memory leak #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
reviewed
Dec 3, 2018
| @@ -190,15 +190,12 @@ impl Isolate { | |||
|
|
|||
| pub fn respond(&mut self, req_id: i32, buf: Buf) { | |||
| self.state.metrics_op_completed(buf.len()); | |||
|
|
|||
| // TODO(zero-copy) Use Buf::leak(buf) to leak the heap allocated buf. And | |||
| // don't do the memcpy in ImportBuf() (in libdeno/binding.cc) | |||
There was a problem hiding this comment.
Looks good - this solves the leak! I think there should be a comment here explaining that memcpy is used.
// deno_respond will memcpy the buf into V8's heap, so borrowing a reference here is sufficient.
There was a problem hiding this comment.
Thanks. The comment is added.
ry
added a commit
to ry/deno
that referenced
this pull request
Dec 7, 2018
- Don't crash when .mime file not exist in cache (denoland#1291) - Process source maps in Rust instead of JS (denoland#1280) - Use alternate TextEncoder/TextDecoder implementation (denoland#1281) - Upgrade flatbuffers to 80d148 - Fix memory leaks (denoland#1265, denoland#1275)
Merged
ry
added a commit
that referenced
this pull request
Dec 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1263
It is hard to achieve zero-copy when passing message between Rust and C, because we can't assume they use the same allocator. There is only one case that zero-copy is easy:
I think deno is not as simple as this. Zero-copy will cost significant API complexity.