Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(watcher): clear screen on each restart #12613

Merged
merged 27 commits into from
Dec 11, 2021

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Oct 31, 2021

Closes #10622

Quality of life improvement:

Screen.Recording.2021-10-31.at.14.14.33.mov

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do other systems do this?

@bartlomieju
Copy link
Member Author

do other systems do this?

I saw it in Vite and Next.js

@lucacasonato
Copy link
Member

I am in favor.

@bartlomieju bartlomieju requested a review from ry October 31, 2021 14:56
@David-Else
Copy link

@ry It would be great to get this merged soon! It is needed in Neovim's terminal to use Deno's built-in testing, without it the results just disappear from the bottom of the terminal as they update. The user has to focus on the terminal window and scroll down, this makes it useless in this situation.

@bartlomieju bartlomieju added this to the 1.17.0 milestone Nov 22, 2021
@Im-Beast
Copy link

Im-Beast commented Dec 4, 2021

I'm not sure whether I should create separate issue for that (because it's QOL improvement just like clearing the screen), but imho after each restart watcher should also disable terminal raw mode (Deno.setRaw), as it makes it impossible to kill running command using Ctrl+C.

@bartlomieju
Copy link
Member Author

I'm not sure whether I should create separate issue for that (because it's QOL improvement just like clearing the screen), but imho after each restart watcher should also disable terminal raw mode (Deno.setRaw), as it makes it impossible to kill running command using Ctrl+C.

@Im-Beast it seems it's not directly related to this PR, so I suggest to open a new issue.

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zifeo
Copy link

zifeo commented Jan 8, 2022

Some feedbacks after a few days using it: works well but should be configurable. This is a real pain on multi environments where files are linked (dylib) and watch/reload chained.

@bartlomieju
Copy link
Member Author

@zifeo please open an issue if you want to have configuration added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add a --clearscreen option to go with --watch for testing
7 participants