-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(watcher): clear screen on each restart #12613
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do other systems do this?
I saw it in Vite and Next.js |
I am in favor. |
@ry It would be great to get this merged soon! It is needed in Neovim's terminal to use Deno's built-in testing, without it the results just disappear from the bottom of the terminal as they update. The user has to focus on the terminal window and scroll down, this makes it useless in this situation. |
I'm not sure whether I should create separate issue for that (because it's QOL improvement just like clearing the screen), but imho after each restart watcher should also disable terminal raw mode ( |
@Im-Beast it seems it's not directly related to this PR, so I suggest to open a new issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Some feedbacks after a few days using it: works well but should be configurable. This is a real pain on multi environments where files are linked (dylib) and watch/reload chained. |
@zifeo please open an issue if you want to have configuration added. |
Closes #10622
Quality of life improvement:
Screen.Recording.2021-10-31.at.14.14.33.mov