Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: stabilize Deno.startTls #12581

Merged
merged 2 commits into from
Oct 29, 2021
Merged

feat: stabilize Deno.startTls #12581

merged 2 commits into from
Oct 29, 2021

Conversation

lucacasonato
Copy link
Member

This commit stabilizes Deno.startTls and removes certFile from the
StartTlsOptions.

Closes #12459

@lucacasonato
feat: stabilize startTls
c1aafe1 
This commit stabilizes `Deno.startTls` and removes `certFile` from the
`StartTlsOptions`.
@lucacasonato lucacasonato changed the title feat: stabilize startTls feat: stabilize Deno.startTls Oct 28, 2021
bartlomieju
bartlomieju approved these changes Oct 29, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please wait on @piscisaureus review before landing

piscisaureus
piscisaureus approved these changes Oct 29, 2021
View reviewed changes
Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
PS: still not a fan of the startTls name :)

@lucacasonato
Copy link
Member Author

We have agreed offline that a name change is not worth it right now if that means this API will not get stabilized in 1.16. Let's ship it!

@lucacasonato lucacasonato merged commit b734143 into denoland:main Oct 29, 2021
@lucacasonato lucacasonato deleted the stabilize_starttls branch October 29, 2021 15:13
@kt3k kt3k mentioned this pull request Aug 23, 2022
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satyarohith satyarohith satyarohith left review comments

@piscisaureus piscisaureus piscisaureus approved these changes

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stabilize Deno.startTls for 1.16
4 participants
@lucacasonato @piscisaureus @bartlomieju @satyarohith