Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tls): Make TLS clients support HTTP/2 #12530

Merged
merged 6 commits into from
Oct 25, 2021

Conversation

andreubotella
Copy link
Contributor

fetch() and client-side websocket used to support HTTP/2, but this regressed in #11491. This patch reenables it by explicitly adding h2 and http/1.1 to the list of ALPN protocols on the HTTP and websocket clients.

Fixes #12517.

Andreu Botella added 2 commits October 25, 2021 05:53
`fetch()` and client-side websocket used to support HTTP/2, but this
regressed in denoland#11491. This patch reenables it by explicitly adding `h2`
and `http/1.1` to the list of ALPN protocols on the HTTP and websocket
clients.

Fixes denoland#12517.
ext/websocket/lib.rs Outdated Show resolved Hide resolved
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks you @andreubotella!

@lucacasonato lucacasonato merged commit e39dace into denoland:main Oct 25, 2021
@andreubotella andreubotella deleted the http2-only-fetch branch October 25, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fetch can't connect to HTTP/2-only servers
2 participants