fix: declare web types as global #12497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
commented
Oct 19, 2021
| @@ -590,6 +614,8 @@ interface WritableStreamDefaultController { | |||
| error(error?: any): void; | |||
| } | |||
|
|
|||
| declare var WritableStreamDefaultController: WritableStreamDefaultController; | |||
There was a problem hiding this comment.
I'm not sure if this one is correct - there's no WritableStreamDefaultController global available, it's just an interface
There was a problem hiding this comment.
That global is available:
~ ❯❯❯ deno 11:28:34
Deno 1.14.3
exit using ctrl+d or close()
> WritableStreamDefaultController
[Function: WritableStreamDefaultController]
| @@ -630,6 +656,8 @@ interface TransformStreamDefaultController<O = any> { | |||
| terminate(): void; | |||
| } | |||
|
|
|||
| declare var TransformStreamDefaultController: TransformStreamDefaultController; | |||
There was a problem hiding this comment.
Same as above, they are both exposed in the global scope, though they don't have constructors. They are exposed for prototype comparison purposes.
Co-authored-by: Feng Yu <[email protected]>
bartlomieju
force-pushed
the
update_web_types
branch
from
def479b
to
6605441
Compare
This was referenced Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12484
Closes #9957
Closes #12387
I checked that denoland/std#1430 passes type check with this PR