Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bundler transforms should match transpile transforms #12418

Merged
merged 1 commit into from
Oct 13, 2021
Merged

fix: bundler transforms should match transpile transforms #12418

merged 1 commit into from
Oct 13, 2021

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Oct 13, 2021 •
edited
Loading

Closes #12412.

Todo:

  • A test... will do a follow up PR that adds a test.

@dsherret dsherret requested a review from kitsonk October 13, 2021 01:56
kitsonk
kitsonk approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I don't have a good minimal reproduction. I have added #12419 to restore the dropped unit tests.

@dsherret dsherret merged commit c2190be into denoland:main Oct 13, 2021
@dsherret dsherret deleted the fix_bundle_panic branch October 13, 2021 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitsonk kitsonk kitsonk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bundler panics when bundling valid code
2 participants
@dsherret @kitsonk