feat(compat): inject Node globals in REPL #12352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
reviewed
Oct 7, 2021
| false, | ||
| ); | ||
| assert!(out.contains("true")); | ||
| assert!(err.contains("Implicitly using latest version")); |
There was a problem hiding this comment.
This will probably change in the future. Maybe instead let's use the --eval <code> flag and have that log out something to the console that indicates it loaded successfully.
There was a problem hiding this comment.
Maybe, I'd rather land as is and make those changes later.
bartlomieju
added a commit
to bartlomieju/deno
that referenced
this pull request
Oct 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.