feat(ext/ffi): add support for buffer arguments #12335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
commented
Oct 5, 2021
piscisaureus
reviewed
Oct 5, 2021
bartlomieju
commented
Oct 5, 2021
Comment on lines
+33
to
+34
| const buffer = new Uint8Array([1, 2, 3, 4, 5, 6, 7, 8]); | ||
| dylib.symbols.print_buffer(buffer, buffer.length); |
There was a problem hiding this comment.
This is a bit unhandy... I wonder if we could just sniff out length automatically in case of ArrayBuffer. Though I think users would still have to declare two parameters... @piscisaureus thoughts?
There was a problem hiding this comment.
I wonder if we could just sniff out length automatically in case of
ArrayBuffer
It's possible of course to sniff out the length automatically on the JS/Rust side (for Uint8Array too, btw).
However C has no standard data type for passing a (pointer, length) tuple.
So I'd just leave it as-is, FFI users can provide their own convenience wrappers.
bartlomieju
added a commit
to bartlomieju/deno
that referenced
this pull request
Oct 6, 2021
…)" This reverts commit 3faf75a.
bartlomieju
added a commit
to bartlomieju/deno
that referenced
this pull request
Oct 10, 2021
This commit adds support for passing buffer arguments across FFI boundary. Co-authored-by: eliassjogreen <[email protected]> Co-authored-by: Bert Belder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forks from #11648