Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some unused benchmarks #12315

Merged
merged 2 commits into from
Oct 6, 2021
Merged

Remove some unused benchmarks #12315

merged 2 commits into from
Oct 6, 2021

Conversation

ry
Copy link
Member

@ry ry commented Oct 4, 2021

  • The throughput benchmarks have never been very revealing and are maybe broken and poorly described on the website.
  • The proxy HTTP benchmarks are also not revealing, take up a lot of time, clutter the graph.

@ry ry requested a review from AaronO October 4, 2021 13:57
@ry ry mentioned this pull request Oct 4, 2021
Merged
AaronO
AaronO approved these changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@AaronO AaronO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit 10c415e into main Oct 6, 2021
@ry ry deleted the remove-benchmarks branch October 6, 2021 02:27
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Oct 10, 2021
@ry @bartlomieju
Remove some unused benchmarks (denoland#12315)
9d28709
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronO AaronO AaronO approved these changes

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ry @AaronO @bartlomieju