feat(tls): custom in memory CA certificates #12219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for using in memory CA certificates for `Deno.startTLS`, `Deno.connectTLS` and `Deno.createHttpClient`. `certFile` is deprecated in `startTls` and `connectTls`, and removed from `Deno.createHttpClient`.
bnoordhuis
approved these changes
Sep 27, 2021
ext/fetch/lib.rs
Outdated
| ca_stores: Option<Vec<String>>, | ||
| ca_file: Option<String>, | ||
| ca_data: Option<ByteString>, | ||
| #[serde(default)] |
There was a problem hiding this comment.
I admit I don't understand what this changes. It's also specified on the type.
There was a problem hiding this comment.
It should force caCerts: undefined to be deserialized as caCerts: []. Essentially use Default::default when the field is falsy or not present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for using in memory CA certificates for
Deno.startTLS,Deno.connectTLSandDeno.createHttpClient.certFileis deprecated instartTlsandconnectTls, and removedfrom
Deno.createHttpClient.Closes #11608.