Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/web): FileReader error messages #12218

Merged
merged 1 commit into from
Sep 25, 2021
Merged

fix(ext/web): FileReader error messages #12218

merged 1 commit into from
Sep 25, 2021

Conversation

rotu
Copy link
Contributor

@rotu rotu commented Sep 25, 2021 •
edited
Loading

Previously FileReader error messages misidentified the failing function.

@CLAassistant
Copy link

CLAassistant commented Sep 25, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@rotu rotu changed the title Stdfix( fix(std): FileReader error messages Sep 25, 2021
@rotu rotu changed the title fix(std): FileReader error messages fix(ext/web): FileReader error messages Sep 25, 2021
satyarohith
satyarohith approved these changes Sep 25, 2021
View reviewed changes
Copy link
Member

@satyarohith satyarohith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @rotu

lucacasonato
lucacasonato approved these changes Sep 25, 2021
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @rotu!

@lucacasonato lucacasonato merged commit 09f2cdb into denoland:main Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

@satyarohith satyarohith satyarohith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rotu @CLAassistant @lucacasonato @satyarohith