Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove depreated Worker::execute_module #12203

Merged
merged 1 commit into from
Sep 24, 2021
Merged

refactor: Remove depreated Worker::execute_module #12203

merged 1 commit into from
Sep 24, 2021

Conversation

ry
Copy link
Member

@ry ry commented Sep 24, 2021

No description provided.

bartlomieju
bartlomieju approved these changes Sep 24, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one more method in deno_core that has been deprecated and could be removed: JsRuntime::load_module. If Deploy is already up to date then LGTM

@ry ry merged commit 80a9a37 into main Sep 24, 2021
@ry ry deleted the rm_execute_module branch September 24, 2021 01:46
caspervonb pushed a commit to caspervonb/deno that referenced this pull request Sep 26, 2021
@ry @caspervonb
refactor: Remove depreated Worker::execute_module (denoland#12203)
069d461
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ry @bartlomieju