Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support serializing WebAssembly.Module objects #12140

Merged
merged 6 commits into from
Sep 29, 2021
Merged

feat: Support serializing WebAssembly.Module objects #12140

merged 6 commits into from
Sep 29, 2021

Conversation

andreubotella
Copy link
Contributor

Closes #11823.

@andreubotella
Copy link
Contributor Author

andreubotella commented Sep 19, 2021 •
edited
Loading

CI will fail because the 0.29.0 release of rusty_v8 hasn't been uploaded to crates.io, and neither has serde_v8 been updated to use it. (See denoland/rusty_v8#782.)

@bartlomieju bartlomieju added this to the 1.15.0 milestone Sep 20, 2021
@andreubotella andreubotella marked this pull request as ready for review September 22, 2021 17:22
lucacasonato
lucacasonato approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks :-)

@lucacasonato lucacasonato merged commit cdb252a into denoland:main Sep 29, 2021
@andreubotella andreubotella deleted the serializable-wasm-module branch September 29, 2021 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.

unable to postMessage with webassembly module
3 participants
@andreubotella @lucacasonato @bartlomieju