Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use import_map crate #11974

Merged
merged 4 commits into from
Sep 11, 2021
Merged

refactor: use import_map crate #11974

merged 4 commits into from
Sep 11, 2021

Conversation

bartlomieju
Copy link
Member

Removes ImportMap implementation from "cli/" and instead
uses import_map crate

dsherret
dsherret approved these changes Sep 10, 2021
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cli/lsp/analysis.rs Outdated Show resolved Hide resolved
@bartlomieju
Copy link
Member Author

Blocked by upstreaming #11976 to import_map

@bartlomieju bartlomieju merged commit d236f43 into denoland:main Sep 11, 2021
@bartlomieju bartlomieju deleted the import_map branch September 11, 2021 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

@kitsonk kitsonk Awaiting requested review from kitsonk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bartlomieju @dsherret