fix(cli): ensure empty lines don't count towards coverage #11957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One known issue, empty lines in transpiled source don't map well.
Main issue here is that range[0] which is the evaluation range gets expanded to include everything. This in turn marks non-executable lines inside the extended range as executable even when they are not.
|
All of the mapping and lookups in this is a prime candidate to make use of the denoland/deno_ast utilities (in a follow up). |
caspervonb
commented
Sep 10, 2021
2359fb8
to
2788e8a
Compare
bartlomieju
approved these changes
Oct 6, 2021
bartlomieju
added a commit
to bartlomieju/deno
that referenced
this pull request
Oct 6, 2021
…noland#11957)" This reverts commit d5b38a9.
bartlomieju
added a commit
that referenced
this pull request
Oct 6, 2021
bartlomieju
pushed a commit
to bartlomieju/deno
that referenced
this pull request
Oct 10, 2021
bartlomieju
added a commit
to bartlomieju/deno
that referenced
this pull request
Oct 10, 2021
…noland#11957)" (denoland#12348) This reverts commit d5b38a9.
|
Since this PR has been reverted, is there any other PR/work in progress to fix coverage that we can follow? |
Unfortunately not |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up coverage by computing the result ahead of time and passing that as-is into the reporter(s).
Doing so, I made sure to throw out empty lines.
Fixes #11327