fix(ext/http): resource leak if request body is not consumed #11955
Conversation
|
On a related note: there are two code paths in EDIT: Disregard, those code paths cause server to raise errors anyway, so probably don't need to handle that. |
| // by server handler | ||
|
|
||
| for (const rid of Object.keys(resourcesBefore)) { | ||
| delete resourcesAfter[Number(rid)]; |
There was a problem hiding this comment.
Why Number? resourcesAfter is not an array, right?
There was a problem hiding this comment.
TS was complaining about rid being any type 🤷
| try { | ||
| SetPrototypeDelete(httpConn.managedResources, requestRid); | ||
| core.close(requestRid); | ||
| } catch { /* pass */ } |
There was a problem hiding this comment.
I don't really understand why it's inside a swallow-everything try/catch - seems like that could hide genuine bugs - but it's a pattern that's used elsewhere in this file so 🤷
There was a problem hiding this comment.
core.close() should only throw BadResource when the thing has already been closed.
Fixes #11926