refactor: factor out DenoSubcommand enum variant into structs #11896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caspervonb
reviewed
Sep 2, 2021
| } | ||
|
|
||
| impl Default for DenoSubcommand { | ||
| fn default() -> DenoSubcommand { | ||
| DenoSubcommand::Repl { eval: None } | ||
| DenoSubcommand::Repl(ReplFlags { eval: None }) |
There was a problem hiding this comment.
Maybe we should implement default for the new command flag sets as-well?
| filter, | ||
| shuffle, | ||
| concurrent_jobs, | ||
| test_flags.include, |
There was a problem hiding this comment.
Nice, this is pretty much exactly what I had in mind.
I'll follow up with a cleanup of these signatures.
| @@ -3665,7 +3712,7 @@ mod tests { | |||
| assert_eq!( | |||
| r.unwrap(), | |||
| Flags { | |||
| subcommand: DenoSubcommand::Test { | |||
| subcommand: DenoSubcommand::Test(TestFlags { | |||
There was a problem hiding this comment.
Tests could be simpler if we used defaults.
There was a problem hiding this comment.
Good point, but I think this could be done in a follow up
dsherret
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #11776 (comment)