Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): pass optional op_init to create_main_worker #11707

Conversation

caspervonb
Copy link
Contributor

@caspervonb caspervonb commented Aug 14, 2021

Replaces the testing flag in create_main_worker with a more general purpose hook to register additional ops.

@caspervonb caspervonb force-pushed the refactor-cli-pass-optional-op-init-to-create-main-worker branch 5 times, most recently from 5009c0b to c5e0693 Compare August 14, 2021 19:44
@caspervonb caspervonb force-pushed the refactor-cli-pass-optional-op-init-to-create-main-worker branch from c5e0693 to b40fd48 Compare August 14, 2021 20:21
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 4b800f5 into denoland:main Aug 17, 2021
@caspervonb caspervonb deleted the refactor-cli-pass-optional-op-init-to-create-main-worker branch August 18, 2021 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants