Add failing byte_order_mark test #11688
Conversation
Doesn't fully fix the issue... there is still something going on with v8 returning the wrong specifier. I think we need to strip the BOM there too.
| @@ -392,10 +393,15 @@ pub fn parse( | |||
| source: &str, | |||
| media_type: &MediaType, | |||
| ) -> Result<ParsedModule, AnyError> { | |||
| let source = strip_bom(source); | |||
There was a problem hiding this comment.
This doesn't fix the entire issue. I wonder if we should be doing this at a higher level?
There was a problem hiding this comment.
Is it V8 that is barfing on it?
There was a problem hiding this comment.
Yes. In core::modules::ModuleMap::new_module module_request.get_specifier(). I haven't looked into it too much.
It's strange that cargo test passes yet running the command explicitly fails. I just did a cargo clean && cargo build && ./target/debug/deno run --no-check cli/tests/testdata/byte_order_mark.ts and it fails.
There was a problem hiding this comment.
Wow, that was weird. I looked into this again just now and ran:
./target/debug/deno run cli/tests/testdata/byte_order_mark.ts...then it suddenly started working again next time I provided --no-check. Caching issue? Anyway, this should be good to go.
No description provided.