Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli/tests): remove unecessary void return types #11577

Merged
merged 2 commits into from
Aug 5, 2021
Merged

fix(cli/tests): remove unecessary void return types #11577

merged 2 commits into from
Aug 5, 2021

Conversation

crowlKats
Copy link
Member

Fixes #8832

@bartlomieju
Copy link
Member

@crowlKats this looks good to me, however tests are failing because some files are checked against lock files and those files got changed in this PR.

bartlomieju
bartlomieju approved these changes Aug 5, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 3f0cf96 into denoland:main Aug 5, 2021
@crowlKats crowlKats deleted the remove_unecessary_return_value branch August 5, 2021 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not require specifying "void" and "Promise<void>" return types
2 participants
@crowlKats @bartlomieju