Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lsp): Implement refactoring #11555

Merged
merged 5 commits into from
Aug 6, 2021
Merged

feat(lsp): Implement refactoring #11555

merged 5 commits into from
Aug 6, 2021

Conversation

jeanp413
Copy link
Contributor

@jeanp413 jeanp413 marked this pull request as draft July 30, 2021 04:57
@jeanp413 jeanp413 marked this pull request as ready for review August 3, 2021 09:28
@jeanp413
Copy link
Contributor Author

jeanp413 commented Aug 3, 2021

ready for review @kitsonk

@kitsonk
Copy link
Contributor

kitsonk commented Aug 3, 2021

@jeanp413 thank you! I will give it a good review first thing tomorrow my time.

@kitsonk kitsonk self-requested a review August 3, 2021 12:26
@bartlomieju bartlomieju added this to the 1.13.0 milestone Aug 3, 2021
kitsonk
kitsonk approved these changes Aug 6, 2021
View reviewed changes
Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Wow! This is awesome 💯 . A really well structured PR that integrates well into what is a fairly complex code base! Thank you.

@kitsonk kitsonk merged commit 728d205 into denoland:main Aug 6, 2021
@jeanp413 jeanp413 deleted the lsp-refactor branch August 6, 2021 04:46
@kitsonk kitsonk mentioned this pull request Nov 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitsonk kitsonk kitsonk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jeanp413 @kitsonk @bartlomieju