Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade Rust to 1.54.0 #11554

Merged
merged 4 commits into from
Jul 30, 2021
Merged

chore: upgrade Rust to 1.54.0 #11554

merged 4 commits into from
Jul 30, 2021

Conversation

magurotuna
Copy link
Member

Upgrades Rust to 1.54.0 and applys clippy's fixes.

@kitsonk
Copy link
Contributor

kitsonk commented Jul 30, 2021

@kt3k I don't know if you know, but it seems that somehow the upgrade to Rust 1.54 causes us to run out of disk space on CI on Windows. I suspect it is something to do with our build caches, but I don't know enough to "fix" it.

@kt3k
Copy link
Member

kt3k commented Jul 30, 2021

'Post Clone repository' step says There is not enough space on the disk. : 'D:\a\_temp\_runner_file_commands\set_env_b44b1bfe-1ffe-40fd-8e4d-37c9df5dd52d', but I think that step only does clean-ups. So I doubt we actually run out of disk space..

'Test release' step shows Error: thread 'basic' panicked at 'assertion failed: build_plugin_output.status.success()', test_plugin\tests\integration_tests.rs:21:3. I guess that one would be the actual problem we need to address

I'll rerun CI anyway

@kitsonk
Copy link
Contributor

kitsonk commented Jul 30, 2021

@kt3k yeah, I re-ran CI already and it continuously fails with the same error... 😕

@bartlomieju
Copy link
Member

@kt3k I don't know if you know, but it seems that somehow the upgrade to Rust 1.54 causes us to run out of disk space on CI on Windows. I suspect it is something to do with our build caches, but I don't know enough to "fix" it.

Changing cache keys here:

- name: Cache Cargo home
uses: actions/cache@v2
with:
# See https://doc.rust-lang.org/cargo/guide/cargo-home.html#caching-the-cargo-home-in-ci
path: |
~/.cargo/registry/index
~/.cargo/registry/cache
~/.cargo/git/db
key: e-cargo-home-${{ matrix.os }}-${{ hashFiles('Cargo.lock') }}
# In main branch, always creates fresh cache
- name: Cache build output (main)
# TODO(kt3k): Change the version to the released version
# when https://github.com/actions/cache/pull/489 (or 571) is merged.
uses: actions/cache@03e00da99d75a2204924908e1cca7902cafce66b
if: matrix.profile == 'release' && github.ref == 'refs/heads/main'
with:
path: |
./target
!./target/*/gn_out
!./target/*/*.zip
!./target/*/*.tar.gz
key: |
d-cargo-target-${{ matrix.os }}-${{ matrix.profile }}-${{ github.sha }}
# Restore cache from the latest 'main' branch build.
- name: Cache build output (PR)
# TODO(kt3k): Change the version to the released version
# when https://github.com/actions/cache/pull/489 (or 571) is merged.
uses: actions/cache@03e00da99d75a2204924908e1cca7902cafce66b
if: github.ref != 'refs/heads/main'
with:
path: |
./target
!./target/*/gn_out
!./target/*/*.zip
!./target/*/*.tar.gz
key: never_saved
restore-keys: |
d-cargo-target-${{ matrix.os }}-${{ matrix.profile }}-

should help

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @magurotuna

@bartlomieju bartlomieju merged commit 8f00b55 into denoland:main Jul 30, 2021
@magurotuna magurotuna deleted the rust-1-54 branch September 9, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants