Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: flaky worker test #11540

Merged
merged 1 commit into from
Jul 28, 2021
Merged

fix: flaky worker test #11540

merged 1 commit into from
Jul 28, 2021

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Jul 27, 2021 •
edited
Loading

The test was flaky because it was using port number that a lot of other tests are using as well.

@bartlomieju bartlomieju requested a review from ry July 27, 2021 20:01
satyarohith
satyarohith approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@satyarohith satyarohith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bartlomieju bartlomieju merged commit c198535 into denoland:main Jul 28, 2021
@bartlomieju bartlomieju deleted the fix_flaky_worker_test branch July 28, 2021 11:12
@bartlomieju bartlomieju mentioned this pull request Jul 29, 2021
Closed
@GJZwiers GJZwiers mentioned this pull request Mar 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satyarohith satyarohith satyarohith approved these changes

@ry ry Awaiting requested review from ry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bartlomieju @satyarohith