Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lsp): ability to set DENO_DIR via settings #11527

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Jul 27, 2021

Ref: denoland/vscode_deno#287

Add the ability to specify an override for the DENO_DIR via the language server configuration. Previously the language server would have to be executed in an environment with the DENO_DIR environment setting, which makes it difficult to manage and customise per workspace.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ideal that it required changes to Flags, but given that comment is explaining well why it's needed this PR looks good to me.

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too.

cli/flags.rs Show resolved Hide resolved
@kitsonk kitsonk merged commit 667b026 into denoland:main Jul 27, 2021
@kitsonk kitsonk deleted the feat_lsp_deno_dir branch July 27, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants