refactor(lsp): minor improvements to handling closed documents #11518
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves #10897 but doesn't completely resolve it.
The problem is that when a document with the same name of another document is re-opened, and that version of the document happened to not be changed, the version is both
"1"
and so tsc things nothing has changed and provides the diagnostics it provided before in response. This means:I looked at how vscode handles this situation with the built in TypeScript language server and they have a complex buffer system where the re-calculate all the diagnostics. I will look into it further down the road, but these changes are the best that can be done right now.