fix(cli/tools/test_runner): side-load test modules #11515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caspervonb
changed the title
This fixes a regression introduced in 1.9 where test modules became main modules by side loading them in a generated module.
caspervonb
force-pushed
the
fix-cli-side-load-test-modules
branch
from
48628bf
to
0663840
Compare
bartlomieju
reviewed
Jul 25, 2021
Comment on lines
+288
to
+294
| let test_file = File { | ||
| local: test_module.to_file_path().unwrap(), | ||
| maybe_types: None, | ||
| media_type: MediaType::JavaScript, | ||
| source: test_source.clone(), | ||
| specifier: test_module.clone(), | ||
| }; |
There was a problem hiding this comment.
Will the module still be typechecked if it's JS by default?
There was a problem hiding this comment.
Yeah we don't seem to care if the entry point is JavaScript or not (which is weird, we should but that's why we're talking about no-check by default I suppose).
I made sure to include the Check diagnostic in the test expectations when I hardened them, and there are no failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in 1.9 where test modules became main modules.
This is undesirable as it will cause executables to start running when they're guarded with
import.meta.main.We now side load (import) the module being tested in a generated module but still mark it as the main module in places where it could be visible like the inspector (effectively everywhere but the import.meta.main flag).
Closes #11504