Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(http/ws): support multiple options in connection header #11505

Merged
merged 2 commits into from
Jul 24, 2021
Merged

fix(http/ws): support multiple options in connection header #11505

merged 2 commits into from
Jul 24, 2021

Conversation

silen-z
Copy link
Contributor

@silen-z silen-z commented Jul 23, 2021

The "connection" header can have multiple connection-options separated by commas:
https://datatracker.ietf.org/doc/html/rfc7230#section-6.1
https://datatracker.ietf.org/doc/html/rfc7230#section-7

Fixes #11494

@CLAassistant
Copy link

CLAassistant commented Jul 23, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

crowlKats
crowlKats approved these changes Jul 23, 2021
View reviewed changes
Copy link
Member

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kitsonk
kitsonk approved these changes Jul 24, 2021
View reviewed changes
Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kitsonk
kitsonk suggested changes Jul 24, 2021
View reviewed changes
Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I think we should change one thing.

extensions/http/01_http.js Outdated Show resolved Hide resolved
kitsonk
kitsonk approved these changes Jul 24, 2021
View reviewed changes
Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@kitsonk kitsonk merged commit 74c7559 into denoland:main Jul 24, 2021
@silen-z silen-z deleted the websocket_multiple_options_connection_header branch July 24, 2021 10:10
@crowlKats crowlKats mentioned this pull request Aug 12, 2021
Merged
@kitsonk kitsonk mentioned this pull request Aug 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitsonk kitsonk kitsonk approved these changes

@crowlKats crowlKats crowlKats approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deno.upgradeWebSocket fails on connection: "keep-alive, Upgrade" header
4 participants
@silen-z @CLAassistant @kitsonk @crowlKats