refactor: use primordials in runtime, extensions and core
#11500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magurotuna
commented
Jul 23, 2021
| const globalIteratorPrototype = ObjectGetPrototypeOf(ObjectGetPrototypeOf( | ||
| [][SymbolIterator](), | ||
| )); | ||
| const globalIteratorPrototype = ObjectGetPrototypeOf(ArrayIteratorPrototype); |
There was a problem hiding this comment.
Not really sure if this change is fine.
Otherwise, could [][SymbolIterator]() be replaced with primordials.ArrayPrototype[SymbolIterator]()? If it could I'd be happy to replace it.
There was a problem hiding this comment.
I'm also not entirely sure if this is correct, but I'm going to tentatively land it
bartlomieju
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm implementing new lint rule
prefer-primordials. To see if it works fine I ran this rule for the runtime, extensions, and core JS code. The linter found a bunch of spots where primordials could be used, so this PR fixes them.ref #11224