Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(runtime): implement navigator.hardwareConcurrency #11448

Merged
merged 15 commits into from
Jul 29, 2021
Merged

feat(runtime): implement navigator.hardwareConcurrency #11448

merged 15 commits into from
Jul 29, 2021

Conversation

littledivy
Copy link
Member

Removes Deno.systemCpuInfo() and closes #9584

ry
ry reviewed Jul 19, 2021
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another reference in cli/dts/lib.deno.unstable.d.ts

lucacasonato
lucacasonato reviewed Jul 19, 2021
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you pass in the cpu count during bootstrapping? (MainWorker::bootstrap / WebWorker::bootstrap)

@lucacasonato lucacasonato added this to the 1.13.0 milestone Jul 19, 2021
lucacasonato
lucacasonato reviewed Jul 19, 2021
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a unit test.

tools/wpt/expectation.json Outdated Show resolved Hide resolved
@littledivy littledivy marked this pull request as ready for review July 19, 2021 15:42
bartlomieju
bartlomieju approved these changes Jul 26, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Divy

@bartlomieju bartlomieju merged commit 2b13bb6 into denoland:main Jul 29, 2021
@littledivy littledivy deleted the hardwareConcurrency branch July 30, 2021 02:15
@bebraw bebraw mentioned this pull request Nov 3, 2021
Closed
@littledivy littledivy mentioned this pull request Sep 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry left review comments

@lucacasonato lucacasonato lucacasonato left review comments

@andreubotella andreubotella andreubotella left review comments

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

Expose window.navigator.hardwareConcurrency
5 participants
@littledivy @ry @lucacasonato @andreubotella @bartlomieju