Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inspector): improve inspector prompt in Chrome Devtools #11187

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Jun 30, 2021

Closes #11135

This commit improves how Deno inspector presents itself in Chrome Devtools.

Before:
123501615-768dee80-d646-11eb-8625-71f749b1ebb6

After:
Screenshot 2021-06-30 at 04 31 36

For comparison here's Node's prompt:
123501616-7988df00-d646-11eb-8e07-b2f27bad417b

@bartlomieju bartlomieju changed the title feat(inspector): improve inspector prompt feat(inspector): improve inspector prompt in Chrome Devtools Jun 30, 2021
Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bartlomieju bartlomieju merged commit 3e21ffc into denoland:main Jun 30, 2021
@bartlomieju bartlomieju deleted the improve_inspector_prompt branch June 30, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inspector prompt in Devtools could be better
2 participants