Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(cli): harden test runner tests #11166

Merged
merged 7 commits into from
Jun 29, 2021
Merged

test(cli): harden test runner tests #11166

merged 7 commits into from
Jun 29, 2021

Conversation

caspervonb
Copy link
Contributor

@caspervonb caspervonb commented Jun 28, 2021 •
edited
Loading

  • Normalizes the naming convention for better filtering
  • Normalizes the wildcards used for output expectations

bartlomieju
bartlomieju approved these changes Jun 29, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for addressing my nitpick, it's great to see improvements like this

@bartlomieju bartlomieju merged commit a0c0daa into denoland:main Jun 29, 2021
@caspervonb caspervonb deleted the test-harden-test-runner-tests branch June 29, 2021 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@caspervonb @bartlomieju