Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(serde_v8): Export serde_v8 just like we export serde_json #11125

Merged
merged 3 commits into from
Jun 26, 2021

Conversation

nicksrandall
Copy link
Contributor

My project is failing to compile because I'm using deno_core::v8 and serde_v8 and the compiler complains about 2 versions of rusty_v8 in my project. I'm hoping this solves the problem?

My project is failing to compile because I'm using `deno_core::v8` and `serde_v8` and the compiler complains about 2 versions of `rusty_v8` in my project. I'm hoping this solves the problem?
@CLAassistant
Copy link

CLAassistant commented Jun 25, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @nicksrandall

@bartlomieju
Copy link
Member

My project is failing to compile because I'm using deno_core::v8 and serde_v8 and the compiler complains about 2 versions of rusty_v8 in my project. I'm hoping this solves the problem?

I'm not sure it's related to missing reexport - make sure you use same version of serde_v8 that deno_core uses that you import in your project. (Of course this PR will solve this as you won't have to specify serde_v8 separately).

@bartlomieju bartlomieju merged commit 2f1ac46 into denoland:main Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants