Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(extensions/fetch): Encode and decode headers as byte strings. #11070

Merged
merged 2 commits into from
Jun 26, 2021
Merged

fix(extensions/fetch): Encode and decode headers as byte strings. #11070

merged 2 commits into from
Jun 26, 2021

Conversation

andreubotella
Copy link
Contributor

@andreubotella andreubotella mentioned this pull request Jun 26, 2021
Closed
lucacasonato
lucacasonato approved these changes Jun 26, 2021
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks :-)

We should apply the same changes to runtime/ops/http.rs for the HTTP server.

@lucacasonato lucacasonato merged commit 015f252 into denoland:main Jun 26, 2021
@andreubotella andreubotella deleted the headers-as-byte-strings branch June 26, 2021 16:01
andreubotella pushed a commit to andreubotella/deno that referenced this pull request Jun 26, 2021
fix(runtime/http): Encode and decode headers as byte strings in the H…
1228686 
…TTP server

See denoland#11070.
@andreubotella andreubotella mentioned this pull request Jun 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Headers should be treated as byte strings
2 participants
@andreubotella @lucacasonato