Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: poll connection after writing response chunk in Deno.serveHttp() #10961

Merged
merged 3 commits into from
Jun 14, 2021
Merged

fix: poll connection after writing response chunk in Deno.serveHttp() #10961

merged 3 commits into from
Jun 14, 2021

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Jun 14, 2021 •
edited
Loading

Still need to come up with a test.

Fixes #10940

lucacasonato
lucacasonato approved these changes Jun 14, 2021
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very nice!

ry
ry reviewed Jun 14, 2021
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I think we’re getting close to stabilizing the http interface after this patch.

@bartlomieju bartlomieju merged commit 1246a43 into denoland:main Jun 14, 2021
@bartlomieju bartlomieju deleted the fix_http_chunk_delay branch June 14, 2021 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry left review comments

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Native http streaming response is always delayed by one chunk
3 participants
@bartlomieju @ry @lucacasonato