refactor: store header keys lower case internally #10958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a minor optimization that removes some header key lowercasing that previously happened on access.
50fe74d
to
b38b8e2
Compare
|
This might have actually had the unfortunate side effect that headers are always lowercased on the wire. For HTTP2 this is the case anyway, but it apparently breaks some HTTP/1 servers that don't understand that headers are case insensitive 🤦♂️. We could fix this while still maintaining the speedup introduced in this PR by introducing a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor optimization that removes some header key lowercasing
that previously happened on access, instead moving it to write.