ci: run Linux release builds in sysroot with Ubuntu 18.04 and LLVM #10920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piscisaureus
force-pushed
the
ci
branch
19 times, most recently
from
03bbad7
to
70ce55d
Compare
1: Github Actions caches are empty. |
piscisaureus
force-pushed
the
ci
branch
2 times, most recently
from
1e6caa0
to
b8817a7
Compare
ry
reviewed
Jun 15, 2021
ry
reviewed
Jun 15, 2021
ry
reviewed
Jun 15, 2021
ry
reviewed
Jun 15, 2021
ry
reviewed
Jun 15, 2021
| git clone --depth 1 --no-checkout \ | ||
| https://github.com/rust-lang/crates.io-index \ | ||
| ~/.cargo/registry/index/github.com-1ecc6299db9ec823 | ||
| fi |
There was a problem hiding this comment.
I don't understand this. Is this related to the sysroot?
There was a problem hiding this comment.
Separated out the commit
There was a problem hiding this comment.
What does this do tho? What is "1ecc6299db9ec823" ? Will it ever need to be updated? I think this could have a comment as to the purpose
There was a problem hiding this comment.
What does this do tho?
As reflected in the name, it makes a shallow clone of the crates.io index.
What is "1ecc6299db9ec823"
I don't know.
Will it ever need to be updated?
I don't know. But in my Rust-using career it has never changed.
I think this could have a comment as to the purpose
The purpose is to make CI faster. Want me add # This makes CI faster?
There was a problem hiding this comment.
# Manually clone the cargo crate index shallowly so that cargo doesn't
# clone it deeply. This saves about 1 minute of CI time. We don't believe the
# identifier '1ecc6299db9ec823' will ever change, but if it does then this command
# must be updated.
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
Jun 23, 2021
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
Jun 23, 2021
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
Jun 23, 2021
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
Jun 23, 2021
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
Jun 23, 2021
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
Jun 23, 2021
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
Jun 23, 2021
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
Jun 23, 2021
...by avoiding a full clone of crates.io index history.
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
Jun 23, 2021
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
Jun 23, 2021
...by avoiding a full clone of crates.io index history.
ry
pushed a commit
that referenced
this pull request
Jun 29, 2021
ry
pushed a commit
that referenced
this pull request
Jun 29, 2021
...by avoiding a full clone of crates.io index history.
ry
pushed a commit
that referenced
this pull request
Jun 29, 2021
ry
pushed a commit
to ry/deno
that referenced
this pull request
Jun 29, 2021
ry
pushed a commit
to ry/deno
that referenced
this pull request
Jun 29, 2021
...by avoiding a full clone of crates.io index history.
ry
pushed a commit
to ry/deno
that referenced
this pull request
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: denoland/rusty_v8#708